Re: [pgadmin4][patch] Use pytest test runner for unit tests

From: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Anthony Emengo <aemengo(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests
Date: 2018-05-24 19:36:37
Message-ID: CAE+jjam92a4rwYM+VxekLTRjLoWdAiPw4MuiCP1dUT_aWc5-6g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

As part of the development environment we do not see the reasoning behind
not add PYTHONPATH to the environment variables, specially because this
looks like the way pytest was invisoned.

However please try the following patch instead. We've changed the pytest
invocation to assume the relevant dir as part of the directories to load,
as well as the docs and Makefile

Thanks
Joao && Anthony

On Thu, May 24, 2018 at 12:24 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Thu, May 24, 2018 at 5:14 PM, Anthony Emengo <aemengo(at)pivotal(dot)io>
> wrote:
>
>> Here’s a followup patch with the relevant README and Makefile changes. To
>> be clear, both patches need to be applied in succession to run the tests.
>>
>> The error that you were running into was because the appropriate
>> PYTHONPATH environment variable was not set. We updated the README to
>> reflect that, but haven’t done anything to the code for that
>>
> That really needs to be fixed then. I shouldn't need to do anything beyond
> activate the appropriate virtual environment (which I had done).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
0002-Use-Pytests-v2.git-diff application/octet-stream 3.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Xuri Gong 2018-05-25 04:00:59 Re: Implement geospatial data viewer in pgAdmin4 for PostGIS
Previous Message Joao De Almeida Pereira 2018-05-24 19:00:14 Re: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery