Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Hello Murtuza,
I do not have the pgAgent installed so it was a little it hard to test this.
After looking into the code I think we are missing some testing coverage
around the pga_job Javascript part so that we can catch these problems.
Even some code extraction can be done around the pg_jobset change

Nevertheless I passed the patch through our CI and it is all green

Thanks
Joao

On Wed, Feb 28, 2018 at 5:36 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> I have found the issue, it was in Backform control itself :)
> Issue: We were passing today's date value as minDate option in pgAgent
> schedule schema while rendering the control, So when server was sending
> previous datetime value it was not displaying it causing sync problem.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Tue, Feb 27, 2018 at 8:39 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> ​Thanks Dave, I'll look into it.
>> ​
>>
>>
>> On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> I'm not able to re-produce the issue, Could you hard refresh and try
>>>> again?
>>>>
>>>
>>> I still see it.
>>>
>>>
>>>>
>>>> If possible could you please provide exact steps?
>>>>
>>>
>>> Attached is a dump of my test pgagent schema.
>>>
>>> 1) Load the schema dump into the maintenance database
>>> 2) Connect pgAdmin
>>> 3) Browse to pgAgent Jobs
>>> 4) Right-click Properties, and select the Schedules tab
>>> 5) Open the subnode for sched1
>>>
>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Sorry - here it is.
>>>>>
>>>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
>>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> Could you please send screenshot?
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Murtuza Zabuawala
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>>
>>>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> Still not quite right - see the attached screenshot which is the
>>>>>>> result of simply viewing the properties of an existing job. Note that the
>>>>>>> start time is shown in the grid but not the subnode control.
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>>>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> As validation related patch was committed with RM#3148 [ Sorry
>>>>>>>> about that I forgot to checkout :) ]
>>>>>>>> PFA patch to fix the issues you mentioned, I have also removed
>>>>>>>> extra error message from sub node collection control and made it optional
>>>>>>>> via flag.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>> Murtuza Zabuawala
>>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <dpage(at)pgadmin(dot)org>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>>>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> PFA patch to fix the issue where user was not able to create
>>>>>>>>>> pgAgent job from UI without entering End date in schedule section.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Whilst this does resolve the validation issue, there are still a
>>>>>>>>> couple of other related problems, as can be seen in the attached
>>>>>>>>> screenshots:
>>>>>>>>>
>>>>>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>>>>>> properly synchronised with the value in the grid.
>>>>>>>>>
>>>>>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>>>>>> first), the grid will show "Invalid date".
>>>>>>>>>
>>>>>>>>> It's possible there are other oddities as well - please check
>>>>>>>>> carefully for anything else.
>>>>>>>>>
>>>>>>>>> Thanks.
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>
>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>