Re: Issue with SlickGrid

Hello Murtuza,
Thanks for the explanation. Based on what you said it looks like a bug in
the library, have you guys considered sending a PR to it?

Thanks

On Thu, Apr 27, 2017, 2:46 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> +++
> Reference:
> https://www.postgresql.org/message-id/CAKKotZRjqbKAZev81Zk78nikDVXqLKEDV5r%2BsW8Me31Gpzrm_A%40mail.gmail.com
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Apr 27, 2017 at 12:09 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hello Joao,
>>
>> Yes, We made some changes in SlickGrid library when we integrated it into
>> Query tool.
>>
>> *Issue:* Last row from the query result set was not displaying correctly
>> in query tool when we have scrollbar in grid.
>>
>> The row hight/width pixel size calculations is done inside SlickGrid
>> javascript code, Though we tried solve it through CSS but we had no luck,
>> so we had no other choice but to do it in library it self.
>>
>> The changes were,
>> 1) "getDataLengthIncludingAddNew()" function (slick.grid.js) to add two
>> new rows instead of one when user add values into row (one row is dummy &
>> not visible to user so that it displays last row correctly)
>> 2) Other change was done into "appendRowHtml()" function to calculating
>> the correct number of rows in SlickGrid result as we have added our own
>> custom row as mentioned earlier.
>> 3) Abbreviated long CSS classes as mentioed in README file.
>>
>> Apologies we missed to update this change in README.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro De Almeida Pereira <
>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>
>>> Hello Hackers,
>>>
>>> While doing some changes to the Query Results we found out that there
>>> was a issue with Slick grid.
>>>
>>> The issue that we found was with the CellSelectModel, behaved
>>> differently when pressing Ctrl and Command(Mac). We created a PR
>>> <https://github.com/6pac/SlickGrid/pull/100> with the change to changes
>>> the behavior of the plugin.
>>>
>>> When this PR is applied to the SlickGrid library we need to apply it to
>>> the current version of SlickGrid that we have vendorized.
>>> According to the libraries.txt file we are in version 2.2.4 of the
>>> library but a diff between our code and the libraries version 2.2.4 shows
>>> differences in the code.
>>>
>>> Did we do any change to SlickGrid library that is vendorized? Or is just
>>> the information in libraries.txt that is incorrect?
>>> Does anyone know any problem if we bump the version of SlickGrid to the
>>> newer version after the PR is applied?
>>>
>>> Thanks
>>> Joao
>>>
>>
>>
>