Re: [patch] Shows titles for disabled buttons on hover

From: Joao Pedro De Almeida Pereira <jpereira(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Sarah McAlear <smcalear(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [patch] Shows titles for disabled buttons on hover
Date: 2017-03-09 19:05:35
Message-ID: CAE+jja=aqcybdYg=6Qc5zjbJh6xMMnq8X=3ekdqkn-G1J1cfRA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Dave,

We were looking into this request and we found at least one location where
the Hover does not make sense when it is disabled (the stylized "i' in the
lower left of dialogs, which has the alt-text "SQL help for this object
type".)

Could this patch be pulled in, as the buttons for which this does not apply
feel out of scope?

Thanks
George & Joao

On Mon, Mar 6, 2017 at 5:42 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Fri, Mar 3, 2017 at 9:19 PM, Sarah McAlear <smcalear(at)pivotal(dot)io> wrote:
> > Hi Hackers,
> >
> > This patch enables hovering over disabled buttons to see their
> > functionality.
>
> This seems to work for the button bar in the query tool, but not for
> other buttons such as those on dialogues. Can you update to fix the
> problem consistently please?
>
> Note that I've created an RM for this issue:
> https://redmine.postgresql.org/issues/2226
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Thanks
Joao

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Atira Odhner 2017-03-09 21:56:16 Re: [patch] Refactor: clipboard, translations, jasmine
Previous Message Begina Felicysym 2017-03-09 17:16:50 Odp: Re: Polish translaction of pgadmin4