From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Joao Pedro De Almeida Pereira <jpereira(at)pivotal(dot)io> |
Cc: | Sarah McAlear <smcalear(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [patch] Shows titles for disabled buttons on hover |
Date: | 2017-03-10 09:06:34 |
Message-ID: | CA+OCxowgOhr5_OiP0MWr7CDKEm-NgagoEsx3NxWhmsXYvLJWdQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Thu, Mar 9, 2017 at 7:05 PM, Joao Pedro De Almeida Pereira
<jpereira(at)pivotal(dot)io> wrote:
> Hello Dave,
>
> We were looking into this request and we found at least one location where
> the Hover does not make sense when it is disabled (the stylized "i' in the
> lower left of dialogs, which has the alt-text "SQL help for this object
> type".)
I think that's debatable. When enabled, that's exactly what the button
would do. I don't think it's any different from other buttons that are
disabled because they don't apply in some circumstances.
> Could this patch be pulled in, as the buttons for which this does not apply
> feel out of scope?
Even if we ignore my comment about about the SQL help button, my
earlier comments still apply. Consistency is fundamental to user
comprehension and learning of a UI - we should not have some disabled
buttons that don't display their tooltips and others that do.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-03-10 10:27:21 | pgAdmin 4 commit: Remove some dead code. |
Previous Message | Dave Page | 2017-03-10 09:03:40 | Re: Polish translaction of pgadmin4 |