| From: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence |
| Date: | 2018-02-21 15:54:28 |
| Message-ID: | CAE+jja=7RNmf5yvSNnfkJ602PX-pte6NOHYBBC65H_Mc+XapRw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Murtuza,
Looks good.
Was there any reason for the change in position of the if statements in the
sql file. Makes the output more readable?
Looks like we need some test to ensure that the Sequence issue does not
happen again. Maybe a Unit Test is good enough, to ensure that we are
creating a good SQL
Thanks
Joao
On Wed, Feb 21, 2018 at 3:13 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patches,
> 1) To fix the validation issue while creating new sequence
> RM#3014
>
> 2) Fix PEP-8 issues in sequence module
> pycodestyle --config=.pycodestyle
> ./pgadmin/browser/server_groups/servers/databases/schemas/sequences/
>
> 3) To fix the regression test for Tablespace when running with Python3.x
> RM#3138
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joao De Almeida Pereira | 2018-02-21 16:22:57 | Re: RM2898 Keyboard navigation in dialog tabs (nav tabs) |
| Previous Message | Joao De Almeida Pereira | 2018-02-21 15:45:16 | Re: [pgAdmin4][Patch]: RM #3077 - ERROR: invalid byte sequence for encoding "LATIN1":0x00 |