| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
| Cc: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#3014] Fix validation issues while creating new sequence |
| Date: | 2018-02-21 16:26:23 |
| Message-ID: | CA+OCxoyU2b0qa7x0f3COzLT2uoBEp9AgSPeVH4rMbm_BFDCH7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Wed, Feb 21, 2018 at 3:54 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:
> Hi Murtuza,
> Looks good.
> Was there any reason for the change in position of the if statements in
> the sql file. Makes the output more readable?
> Looks like we need some test to ensure that the Sequence issue does not
> happen again. Maybe a Unit Test is good enough, to ensure that we are
> creating a good SQL
>
I think we need to come up with a framework or standard method for testing
the generated SQL and reverse engineered SQL for all objects. That's been
bugging me for a while - the problem is that for just a single object type
there may be thousands of possible combinations of options to test to
ensure complete coverage.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-02-21 16:31:46 | Re: RM2898 Keyboard navigation in dialog tabs (nav tabs) |
| Previous Message | Dave Page | 2018-02-21 16:23:34 | Re: [pgadmin4] Priorities of features |