| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Autogenerate some wait events code and documentation |
| Date: | 2023-03-30 16:41:27 |
| Message-ID: | CADkLM=eF=Sa1D36vrNAhb5MGhH8HUQ5gHKm2B_OZ1y8kh34k_w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 29, 2023 at 8:51 AM Drouvot, Bertrand <
bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> Hi,
>
> On 3/29/23 11:44 AM, Drouvot, Bertrand wrote:
>
> >
> > Looking forward to your feedback,
>
> Just realized that more polishing was needed.
>
> Done in V2 attached.
>
> Regards,
>
> --
> Bertrand Drouvot
> PostgreSQL Contributors Team
> RDS Open Source Databases
> Amazon Web Services: https://aws.amazon.com
I think this is good work, but I can't help thinking it would be easier to
understand and maintain if we used a template engine like Text::Template,
and filled out the template with the variant bits. I'll ask that question
in another thread for higher visibility.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2023-03-30 17:06:46 | Thoughts on using Text::Template for our autogenerated code? |
| Previous Message | Masahiko Sawada | 2023-03-30 16:31:41 | Re: Minimal logical decoding on standbys |