From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
---|---|
To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, alvherre(at)alvh(dot)no-ip(dot)org |
Subject: | Re: Statistics Import and Export |
Date: | 2024-08-04 05:09:40 |
Message-ID: | CADkLM=e0jM7m0GFV44nNtvL22CtnFUu+pekppCVE=DOBe58RTQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>
>
> > WARNING: invalid input syntax for type integer: "four"
> > row_written | stats_applied |
> > stats_rejected | params_rejected
> > -------------+----------------------------------+--------------------
> > ------------------+-----------------
> > t | {null_frac,avg_width,n_distinct} |
> > {most_common_vals,most_common_freqs} |
> > (1 row)
>
> I think I like this, as well, except for the return value, which seems
> like too much information and a bit over-engineered. Can we simplify it
> to what's actually going to be used by pg_upgrade and other tools?
>
pg_upgrade currently won't need any of it, it currently does nothing when a
statistics import fails. But it could do *something* based on this
information. For example, we might have an option
--analyze-tables-that-have-a-statistics-import-failure that analyzes tables
that have at least one statistics that didn't import. For instance,
postgres_fdw may try to do stats import first, and if that fails fall back
to a remote table sample.
We could do other things. It seems a shame to just throw away this
information when it could potentially be used in the future.
>
> > Attached is v25.
>
> I believe 0001 and 0002 are in good shape API-wise, and I can start
> getting those committed. I will try to clean up the code in the
> process.
>
:)
From | Date | Subject | |
---|---|---|---|
Next Message | Imran Zaheer | 2024-08-04 07:02:07 | Re: SQL Property Graph Queries (SQL/PGQ) |
Previous Message | Robert Treat | 2024-08-04 03:29:59 | Re: PG 17 and GUC variables |