| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Ilya Gladyshev <ilya(dot)v(dot)gladyshev(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: optimizing pg_upgrade's once-in-each-database steps |
| Date: | 2024-08-08 22:18:38 |
| Message-ID: | CADkLM=e0KxKJH0XSG6x2oGK7-W2Eet4AwwCqz5pxAG7QthX4Xw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 6, 2024 at 3:20 PM Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:
> On Sun, Aug 04, 2024 at 07:19:57PM +0100, Ilya Gladyshev wrote:
> > -- End of review --
>
> Thanks for the review. I've attempted to address all your feedback in v8
> of the patch set. I think the names could still use some work, but I
> wanted to get the main structure in place before trying to fix them.
>
I think the underlying mechanism is basically solid, but I have one
question: isn't this the ideal case for using libpq pipelining? That would
allow subsequent tasks to launch while the main loop slowly gets around to
clearing off completed tasks on some other connection.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abdoulaye Ba | 2024-08-08 22:20:41 | Re: PATCH: Add hooks for pg_total_relation_size and pg_indexes_size |
| Previous Message | Matthew Kim | 2024-08-08 22:16:37 | Re: Remove dependence on integer wrapping |