| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add SHELL_EXIT_CODE to psql |
| Date: | 2022-12-30 19:17:19 |
| Message-ID: | CADkLM=dxXa1axRoeeMvrdCucfUJsCxuQhyoWMZkKGPQ1cfp2Fw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 28, 2022 at 5:59 AM Maxim Orlov <orlovmg(at)gmail(dot)com> wrote:
> Hi!
>
> The patch is implementing what is declared to do. Shell return code is now
> accessible is psql var.
> Overall code is in a good condition. Applies with no errors on master.
> Unfortunately, regression tests are failing on the macOS due to the
> different shell output.
>
That was to be expected.
I wonder if there is value in setting up a psql on/off var
SHELL_ERROR_OUTPUT construct that when set to "off/false"
suppresses standard error via appending "2> /dev/null" (or "2> nul" if
#ifdef WIN32). At the very least, it would allow for tests like this to be
done with standard regression scripts.
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-12-30 19:53:50 | Re: Crash in BRIN minmax-multi indexes |
| Previous Message | Nathan Bossart | 2022-12-30 18:51:43 | Re: Rework confusing permissions for LOCK TABLE |