Re: [pgjdbc] Check code style via automated tool (#295)

Yes, we can add code style change to the post-mavenization items

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On 20 June 2015 at 16:11, Markus KARG <markus(at)headcrashing(dot)eu> wrote:

> I second that.
>
>
>
> I do not see that Maven is a big change, as we agreed to decouple it form
> any other change.
>
>
>
> So we should add code style change to the list of post-mavenization items.
>
>
>
> *From:* Vladimir Sitnikov [mailto:notifications(at)github(dot)com]
> *Sent:* Samstag, 20. Juni 2015 17:59
> *To:* pgjdbc/pgjdbc
> *Cc:* Markus KARG
> *Subject:* Re: [pgjdbc] Check code style via automated tool (#295)
>
>
>
> actually since maven will be a big PR; we might as well change the code
> style (as long as it doesn't end up in a religious argument)
>
> That does not work that way.
> I think it is better to separate "mavenization" and "big changes".
> Otherwise git might fail recognizing file renames.
>
> I think this would simplify review and rebasing of on-going PRs.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pgjdbc/pgjdbc/issues/295#issuecomment-113786363>.
>