Re: [pgjdbc] Check code style via automated tool (#295)

From: "Markus KARG" <markus(at)headcrashing(dot)eu>
To: "'List'" <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: [pgjdbc] Check code style via automated tool (#295)
Date: 2015-06-20 20:11:20
Message-ID: 006201d0ab95$467f0270$d37d0750$@eu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

I second that.

I do not see that Maven is a big change, as we agreed to decouple it form any other change.

So we should add code style change to the list of post-mavenization items.

From: Vladimir Sitnikov [mailto:notifications(at)github(dot)com]
Sent: Samstag, 20. Juni 2015 17:59
To: pgjdbc/pgjdbc
Cc: Markus KARG
Subject: Re: [pgjdbc] Check code style via automated tool (#295)

actually since maven will be a big PR; we might as well change the code
style (as long as it doesn't end up in a religious argument)

That does not work that way.
I think it is better to separate "mavenization" and "big changes".
Otherwise git might fail recognizing file renames.

I think this would simplify review and rebasing of on-going PRs.


Reply to this email directly or view it on GitHub <https://github.com/pgjdbc/pgjdbc/issues/295#issuecomment-113786363> . <https://github.com/notifications/beacon/ABn3t-TtJP5HBLWd6ns5QBSY27onB-Xpks5oVYVSgaJpZM4Ex3zB.gif>

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Dave Cramer 2015-06-20 20:40:21 Re: [pgjdbc] Check code style via automated tool (#295)
Previous Message Markus KARG 2015-06-20 20:07:34 Re: [pgjdbc] chore: migrate the build to Maven (#322)