From: | Phil Sorber <phil(at)omniti(dot)com> |
---|---|
To: | Jon Erdman <postgresql(at)thewickedtribe(dot)net> |
Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: My first patch! (to \df output) |
Date: | 2013-01-23 17:50:48 |
Message-ID: | CADAkt-ibd_D9F5p5wuqUYmi75AL1ftfUHiO_YgGAus_VT53hOQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 23, 2013 at 12:31 AM, Jon Erdman
<postgresql(at)thewickedtribe(dot)net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> Done. Attached.
> - --
> Jon T Erdman (aka StuckMojo)
> PostgreSQL Zealot
>
> On 01/22/2013 11:17 PM, Phil Sorber wrote:
>> On Wed, Jan 23, 2013 at 12:10 AM, Jon Erdman
>> <postgresql(at)thewickedtribe(dot)net> wrote:
>>
>> Updated the patch in commitfest with the doc change, and added a
>> comment to explain the whitespace change (it was to clean up the
>> sql indentation). I've also attached the new patch here for
>> reference.
>>
>>> Docs looks good. Spaces gone.
>>
>>> Still need to replace 'definer' and 'invoker' with %s and add
>>> the corresponding gettext_noop() calls I think.
>>
This looks good to me now. Compiles and works as described.
One thing I would note for the future though, when updating a patch,
add a version to the file name to distinguish it from older versions
of the patch.
> -----BEGIN PGP SIGNATURE-----
> Comment: Using GnuPG with undefined - http://www.enigmail.net/
>
> iEYEARECAAYFAlD/dcoACgkQRAk1+p0GhSEKHQCZAW8UNqSjYxBgBvt2nuffrkrV
> +9AAn1hChpY5Jg8G8T3XmlIb+3VUSEQ2
> =3cFD
> -----END PGP SIGNATURE-----
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Berkus | 2013-01-23 17:51:15 | Re: CF3+4 (was Re: Parallel query execution) |
Previous Message | Simon Riggs | 2013-01-23 17:48:53 | Re: [COMMITTERS] pgsql: Improve concurrency of foreign key locking |