Re: CF3+4 (was Re: Parallel query execution)

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Phil Sorber <phil(at)omniti(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CF3+4 (was Re: Parallel query execution)
Date: 2013-01-23 17:51:15
Message-ID: 51002313.5060702@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/23/2013 09:08 AM, Andres Freund wrote:
> On 2013-01-23 11:44:29 -0500, Robert Haas wrote:
>> On Tue, Jan 22, 2013 at 1:15 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Yeah, and a lot more fairly-new developers who don't understand all the
>>> connections in the existing system. Let me just push back a bit here:
>>> based on the amount of time I've had to spend fixing bugs over the past
>>> five months, 9.2 was our worst release ever. I don't like that trend,
>>> and I don't want to see it continued because we get laxer about
>>> accepting patches. IMO we are probably too lax already.
>>
>> Really? Hmm, that's not good. I seem to recall 8.4.x being pretty
>> bad, and some of the recent bugs we fixed were actually 9.1.x problems
>> that slipped through the cracks.
>
> FWIW I concur with Tom's assessment.

The only way to fix increasing bug counts is through more-comprehensive
regular testing. Currently we have regression/unit tests which cover
maybe 30% of our code. Performance testing is largely ad-hoc. We don't
require comprehensive acceptance testing for new patches. And we have >
1m lines of code. Of course our bug count is increasing.

I'm gonna see if I can do something about improving our test coverage.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2013-01-23 17:54:36 Re: proposal: fix corner use case of variadic fuctions usage
Previous Message Phil Sorber 2013-01-23 17:50:48 Re: My first patch! (to \df output)