| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB. |
| Date: | 2024-11-10 07:12:19 |
| Message-ID: | CAD5tBcKnE3C1hycBYZYtYpNssQR_e+u2=CmDhGRFvDMEg3onRg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sat, Nov 9, 2024 at 11:20 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Sat, Nov 9, 2024 at 9:30 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > My impression was that this was something we just didn't get around to.
> I wouldn't have pushed these so close to release if this hadn't been code
> already tested for a long time in release 16+. Maybe we missed something,
> but I doubt it.
>
> c5cb8f3b did have a couple more follow-ups: 4517358e and f71007fb.
> These fixed initdb when run under a junction point:
>
>
> https://www.postgresql.org/message-id/4590c37927d7b8ee84f9855d83229018%40postgrespro.ru
Oh, ouch. I guess it's too late to add those for this release. Still, an
initdb failure is not as bad as a pg_rewind failure, IMNSHO.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-11-10 18:41:08 | pgsql: Release notes for 17.1, 16.5, 15.9, 14.14, 13.17, 12.21. |
| Previous Message | Thomas Munro | 2024-11-09 00:49:40 | Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB. |