| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB. |
| Date: | 2024-11-10 20:46:03 |
| Message-ID: | CA+hUKGKWG0L8DJA+=Rs_cT27wEQUg-LGM1WWaBYx+74GGK8s6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, Nov 10, 2024 at 8:12 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Oh, ouch. I guess it's too late to add those for this release. Still, an initdb failure is not as bad as a pg_rewind failure, IMNSHO.
Yeah, I don't think it's all that bad. It seems both unlikely
(certain kinds of junction points with no intermediate directories, or
chains of junction points), and easy to work around once you get the
idea by experimentation (probably: add subdir, or tell initdb the real
target path directly, or move into place).
In hindsight I should have posted that observation onto the -hackers
thread where people able to test on Windows would have been more
likely to act, not buried here in -committers (and I didn't want to
commit blind to pre-CI branches in a hurry myself). Sorry about that.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-11-10 23:09:24 | pgsql: jit: Remove obsolete LLVM version guard. |
| Previous Message | Tom Lane | 2024-11-10 20:45:42 | pgsql: Fix broken collate.icu.utf8 test in v12 branch. |