From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Setting pd_lower in GIN metapage |
Date: | 2017-06-26 03:25:50 |
Message-ID: | CAD21AoDn4sV3Gst0KC0VS8bf1H435mz2KTgvqX5m1VN6sq-VzQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Jun 24, 2017 at 1:35 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Masahiko Sawada wrote:
>> On Fri, Jun 23, 2017 at 3:31 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> > On Fri, Jun 23, 2017 at 3:17 PM, Amit Langote
>> > <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> >> Initially, I had naively set wal_consistency_check = all before running
>> >> make installcheck and then had to wait for a long time to confirm that WAL
>> >> generated by the gin test indeed caused consistency check failure on the
>> >> standby with the v1 patch.
>> >
>> > wal_consistency_check = gin would have saved you a lot of I/O.
>> >
>> >> But I can see Sawada-san's point that there should be some way for
>> >> developers writing code that better had gone through WAL consistency
>> >> checking facility to do it without much hassle. But then again, it may
>> >> not be that frequent to need that.
>>
>> Yeah, it should be optional. I imagined providing such an option of
>> pg_regress or TAP test for the developers.
>
> As far as I know it is possible to have third-party modules that extend
> the buildfarm client script so that it runs additional tests that the
> standard ones. You could have a custom module installed in some
> powerful machine of yours that runs the WAL consistency check and report
> the results to the buildfarm. A single animal running that test should
> be enough, right?
>
Yes, thank you for the information. It's a good idea. I'll try it.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2017-06-26 04:00:30 | Re: Setting pd_lower in GIN metapage |
Previous Message | Craig Ringer | 2017-06-26 03:12:10 | Re: Timing-sensitive case in src/test/recovery TAP tests |