Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, tharakan(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string
Date: 2025-03-12 23:24:39
Message-ID: CAD21AoDh4yW+rYOVtpfK1cqpmCCBy=A=Sk4QB5sg6qzaA=GWig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Mar 12, 2025 at 3:00 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Wed, Mar 12, 2025 at 02:33:36PM -0700, Masahiko Sawada wrote:
> > Thank you for the report! David also reported the same issue[1]. I've
> > just pushed the fix.
>
> Oh, sorry, I should've checked that list first.
>
> > BTW how did you catch the warning? I checked before the push if the
> > change had passed the CI tests (completed with green status). But when
> > checking the build log now, I can see the warning in the build logs.
>
> I noticed a ⚠ next to the results on http://cfbot.cputube.org/.

That's good to know. Thank you. I'll add it to my pre-commit check routine.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2025-03-12 23:37:33 Re: BUG #18840: Segmentation fault in executing select unnest(array(oidvector))
Previous Message Andres Freund 2025-03-12 22:45:52 Re: Attribute of type record has wrong type error with MERGE ... WHEN NOT MATCHED BY SOURCE THEN DELETE