| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use the enum value CRS_EXPORT_SNAPSHOT instead of "0" |
| Date: | 2023-06-16 08:16:22 |
| Message-ID: | CAD21AoDM7GwJfYmhwhdMLmw1dJjAijKyO+W6S-oHi7_CzqtpVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 16, 2023 at 3:10 PM Wei Wang (Fujitsu)
<wangw(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Hi,
>
> In the function WalReceiverMain, when the function walrcv_create_slot is called,
> the fourth parameter is assigned the value "0" instead of the enum value
> "CRS_EXPORT_SNAPSHOT". I think it would be better to use the corresponding enum
> value.
The walreceiver process doesn't use CRS_EXPORT_SNAPSHOT actually,
right? I think replacing it with CRS_EXPORT_SNAPSHOT would rather
confuse me
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Quan Zongliang | 2023-06-16 09:25:16 | Incorrect estimation of HashJoin rows resulted from inaccurate small table statistics |
| Previous Message | Kyotaro Horiguchi | 2023-06-16 07:51:38 | Re: add non-option reordering to in-tree getopt_long |