From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Masahiko Sawada <msawada(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus |
Date: | 2025-03-17 22:01:43 |
Message-ID: | CAD21AoCB3CORap1fYVHUiAAuK7t9LGGoYqr1hm-2-LP3DR63uw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, Mar 17, 2025 at 10:20 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Fri, Feb 21, 2025 at 1:20 PM Masahiko Sawada <msawada(at)postgresql(dot)org> wrote:
> > pg_upgrade: Preserve default char signedness value from old cluster.
>
> Hi,
>
> I noticed that after running 'meson test --suite setup --suite
> pg_upgrade', the file delete_old_cluster.sh is left behind in the
> source directory, which should not happen. Everything created for the
> tests should be created in the meson directories. I traced the problem
> down to 005_char_signedness.pl. I believe the problem is likely that
> other pg_upgrade TAP tests include this locution, whereas
> 005_char_signedness.pl does not:
>
> # In a VPATH build, we'll be started in the source directory, but we want
> # to run pg_upgrade in the build directory so that any files generated finish
> # in it, like delete_old_cluster.{sh,bat}.
> chdir ${PostgreSQL::Test::Utils::tmp_check};
Thank you for the report.
I've confirmed the issue and attached a patch to fix it.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-the-test-005_char_signedness.patch | application/octet-stream | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2025-03-17 23:23:42 | pgsql: aio: Add core asynchronous I/O infrastructure |
Previous Message | Nathan Bossart | 2025-03-17 20:58:23 | pgsql: Add commit 203c1b4cc4 to .git-blame-ignore-revs. |
From | Date | Subject | |
---|---|---|---|
Next Message | Jelte Fennema-Nio | 2025-03-17 22:11:15 | Re: Next commitfest app release is planned for March 18th |
Previous Message | Melanie Plageman | 2025-03-17 21:46:04 | Re: BitmapHeapScan streaming read user and prelim refactoring |