From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Masahiko Sawada <msawada(at)postgresql(dot)org> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus |
Date: | 2025-03-17 17:20:22 |
Message-ID: | CA+TgmoYg5e4oznn0XGoJ3+mceG1qe_JJt34rF2JLwvGS5T1hgQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Feb 21, 2025 at 1:20 PM Masahiko Sawada <msawada(at)postgresql(dot)org> wrote:
> pg_upgrade: Preserve default char signedness value from old cluster.
Hi,
I noticed that after running 'meson test --suite setup --suite
pg_upgrade', the file delete_old_cluster.sh is left behind in the
source directory, which should not happen. Everything created for the
tests should be created in the meson directories. I traced the problem
down to 005_char_signedness.pl. I believe the problem is likely that
other pg_upgrade TAP tests include this locution, whereas
005_char_signedness.pl does not:
# In a VPATH build, we'll be started in the source directory, but we want
# to run pg_upgrade in the build directory so that any files generated finish
# in it, like delete_old_cluster.{sh,bat}.
chdir ${PostgreSQL::Test::Utils::tmp_check};
Regards,
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2025-03-17 18:09:30 | pgsql: pg_combinebackup: Add -k, --link option. |
Previous Message | Tom Lane | 2025-03-17 16:53:55 | pgsql: Unify wording of user-facing "row security" messages. |
From | Date | Subject | |
---|---|---|---|
Next Message | Jacob Champion | 2025-03-17 17:22:47 | Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible |
Previous Message | Andres Freund | 2025-03-17 17:18:55 | Re: Incorrect result of bitmap heap scan. |