Re: Potential data loss due to race condition during logical replication slot creation

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Callahan, Drew" <callaan(at)amazon(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: Potential data loss due to race condition during logical replication slot creation
Date: 2024-07-10 02:21:48
Message-ID: CAD21AoBm5_FzZFoFcfPf8c2G91hE4soQOiy_QAM1-mwv-UryXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Jul 10, 2024 at 10:15 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> If we go this approach,
> I think we should check if the flag is set before finding the start
> point.

Checking if the flag is set in DecodingContextFindStartpoint()
requires introducing a new function in snapbuild.c and the function
would be used only in an Assertion. So the attached updated patch
doesn't introduce such a function. If it's really worth it, I can add
it, but I think we can live without that.

Overall I think the patches are in good shape, so I'm going to push
them tomorrow, barring any objections and further comments.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
master_v3-0001-Fix-possibility-of-logical-decoding-partial-trans.patch application/octet-stream 13.4 KB
REL17_v3-0001-Fix-possibility-of-logical-decoding-partial-trans.patch application/octet-stream 13.4 KB
REL15_v3-0001-Fix-possibility-of-logical-decoding-partial-trans.patch application/octet-stream 11.4 KB
REL14_v3-0001-Fix-possibility-of-logical-decoding-partial-trans.patch application/octet-stream 11.3 KB
REL16_v3-0001-Fix-possibility-of-logical-decoding-partial-trans.patch application/octet-stream 11.9 KB
REL13_v3-0001-Fix-possibility-of-logical-decoding-partial-trans.patch application/octet-stream 11.3 KB
REL12_v3-0001-Fix-possibility-of-logical-decoding-partial-trans.patch application/octet-stream 11.3 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Amit Kapila 2024-07-10 03:43:27 Re: Potential data loss due to race condition during logical replication slot creation
Previous Message Masahiko Sawada 2024-07-10 01:15:37 Re: Potential data loss due to race condition during logical replication slot creation