Re: Proposal : REINDEX SCHEMA

On Tuesday, December 9, 2014, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:

> On 9 December 2014 at 17:17, Michael Paquier <michael(dot)paquier(at)gmail(dot)com
> <javascript:;>> wrote:
>
> >> While re-looking at that. I just found that when selecting the
> >> relations that are reindexed for a schema we ignore materialized view
> >> as the key scan is only done using 'r' as relkind. The patch attached
> >> fixes that.
> > Here is an updated patch doing as well that:
> > - Regression test checking if user has permissions on schema was broken
> > - Silent NOTICE messages of REINDEX by having client_min_messages set
> > to WARINING (thoughts about having a plpgsql function doing
> > consistency checks of relfilenode before and after reindex?)
>
> ISTM that REINDEX is not consistent with VACUUM, ANALYZE or CLUSTER in
> the way it issues NOTICE messages.
>
> I'm inclined to simply remove the NOTICE messages, except when a
> REINDEX ... VERBOSE is requested.
>
>
+1 to remove the NOTICE messages except when specifying VERBOSE.

It would output a lot of messages if there are many table in schema.
If nobody objects to it, I will work on this.

Regards,

--
Sawada Masahiko

--
Regards,

-------
Sawada Masahiko