Question on LWLockMode in dsa.c

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: John Naylor <johncnaylorls(at)gmail(dot)com>
Subject: Question on LWLockMode in dsa.c
Date: 2024-01-30 00:53:19
Message-ID: CAD21AoALgrU2sGWzgq+6G9X0ynqyVOjMR5_k4HgsGRWae1j=wQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While working on radix tree patch[1], John Naylor found that dsa.c
doesn't already use shared locks even in dsa_dump(). dsa_dump() seems
a pure read-only function so I thought we could use a shared lock mode
there. Is there any reason to use exclusive mode even in dsa_dump()?

Ultimately, since we're trying to add a new function
dsa_get_total_size() that just returns
dsa_area_control.total_segment_size and therefore would also be a
read-only function, I'd like to find out the correct lock mode there.

Regards,

[1] https://www.postgresql.org/message-id/CANWCAZYYzoKp_4%2B1m5mn-TRD62BTwom8iLXLOWMsHkkwFi%3Drzg%40mail.gmail.com

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-01-30 00:55:35 Re: [PoC] Improve dead tuple storage for lazy vacuum
Previous Message Michael Paquier 2024-01-30 00:51:01 Re: Use of backup_label not noted in log