Re: [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

From: Atul Sharma <atul(dot)sharma(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server
Date: 2017-06-09 12:34:40
Message-ID: CACsXrw6ucKsSh+YnTSpCO7hxsGoUq_b-CGfwNCkoz8Z+ZrEq7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

I have made the template search code to work for 10_plus directory name.
Please review the attached patch

Regards,
Atul.

On Thu, Jun 8, 2017 at 7:55 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi Atul,
>
> On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma
> <atul(dot)sharma(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > The issue is fixed now. Added a new "stats.sql" file with updated columns
> > for the version 10.0_plus
> >
> > PFA RM patch.
>
> As PostgreSQL has moved to a 2 digit version number system instead of
> 3, I think the directory name should be 10_plus shouldn't it? Will
> that work with the template search code? If not, can you please fix
> that as well?
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
RM_2450_ver1.patch application/octet-stream 6.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shirley Wang 2017-06-09 13:05:50 Re: [patch] Changing the ACI tree font to Helvetica
Previous Message Surinder Kumar 2017-06-09 09:40:58 Re: [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button