Re: [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Atul Sharma <atul(dot)sharma(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server
Date: 2017-06-12 11:53:25
Message-ID: CA+OCxoyXcQzRz98jSKrfdSJCpk+vRXD8n+aD+E-C8AmdnLLezA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks Atul, patch applied.

On Fri, Jun 9, 2017 at 1:34 PM, Atul Sharma
<atul(dot)sharma(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> I have made the template search code to work for 10_plus directory name.
> Please review the attached patch
>
> Regards,
> Atul.
>
>
>
> On Thu, Jun 8, 2017 at 7:55 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi Atul,
>>
>> On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma
>> <atul(dot)sharma(at)enterprisedb(dot)com> wrote:
>> > Hi,
>> >
>> > The issue is fixed now. Added a new "stats.sql" file with updated
>> > columns
>> > for the version 10.0_plus
>> >
>> > PFA RM patch.
>>
>> As PostgreSQL has moved to a 2 digit version number system instead of
>> 3, I think the directory name should be 10_plus shouldn't it? Will
>> that work with the template search code? If not, can you please fix
>> that as well?
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-06-12 11:55:32 Re: [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button
Previous Message Dave Page 2017-06-12 11:53:12 pgAdmin 4 commit: Fix error on the stats tab with PG10. Also, rename th