Re: Another XML build issue

From: Kevin Grittner <kgrittn(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Another XML build issue
Date: 2015-12-14 18:02:21
Message-ID: CACjxUsOSVj9kVO-t7AWz7D5F6pOiR88NzJL_64fSz0HgxiQb0w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 14, 2015 at 10:56 AM, Kevin Grittner <kgrittn(at)gmail(dot)com> wrote:
> On Mon, Dec 14, 2015 at 10:43 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>> As I said, my inclination is to remove the SELECT xmlparse(document '')
>> test case altogether. The following test SELECT xmlparse(document ' ')
>> seems like it provides as much useful coverage as we need for that,
>> and its output doesn't depend on whether libxml2 continues parsing
>> after the first error.
>
> That's fine with me. I can do that, if there are no objections.
> (It is easy enough to find the affected lines in all 3 "expected"
> files.)

This didn't seem terribly controversial, so pushed.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul Ramsey 2015-12-14 18:27:27 Re: parallel joins, and better parallel explain
Previous Message Jim Nasby 2015-12-14 17:57:59 Re: Remove array_nulls?