Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL

From: Önder Kalacı <onderkalaci(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Date: 2023-03-17 07:38:02
Message-ID: CACawEhWkFwQ5Zuu9NOQiJtjnQY+At8JuhKQ6cJ7wEvWv+Vb=+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Amit, all

> You can first submit the fix for dropped columns with patches till
> v10. Once that is committed, then you can send the patches for
> generated columns.
>
>
Alright, attaching 2 patches for dropped columns, the names of the files
shows which
versions the patch can be applied to:
v2-0001-Ignore-dropped-columns-HEAD-REL_15-REL_14-REL_13.patch
v2-0001-Ignore-dropped-columns-REL_12-REL_11.patch

And, then on top of that, you can apply the patch for generated columns on
all applicable
versions (HEAD, 15, 14, 13 and 12). It applies cleanly. The name of the
file
is: v2-0001-Ignore-generated-columns.patch

But unfortunately I couldn't test the patch with PG 12 and below. I'm
getting some
unrelated compile errors and Postgrees CI is not available on
these versions . I'll try
to fix that, but I thought it would still be good to share the patches as
you might
already have the environment to run the tests.

Don't worry about v10 --- that's out of support and shouldn't
> get patched for this.

Given this information, I skipped the v10 patch.

Thanks,
Onder KALACI

Attachment Content-Type Size
v2-0001-Ignore-dropped-columns-REL_12-REL_11.patch application/octet-stream 3.4 KB
v2-0001-Ignore-dropped-columns-HEAD-REL_15-REL_14-REL_13.patch application/octet-stream 3.6 KB
v2-0001-Ignore-generated-columns.patch application/octet-stream 2.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2023-03-17 07:49:33 Re: [PoC] Improve dead tuple storage for lazy vacuum
Previous Message Bharath Rupireddy 2023-03-17 07:20:09 Re: Add pg_walinspect function with block info columns