| From: | Jerry Jelinek <jerry(dot)jelinek(at)joyent(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch to allow disable of WAL recycling |
| Date: | 2019-03-07 21:12:59 |
| Message-ID: | CACPQ5Fo=zpJptcTaoRZRM7bFHM9ihFcKcHnWVk0duMem++CG8Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 6, 2019 at 4:14 PM Jerry Jelinek <jerry(dot)jelinek(at)joyent(dot)com>
wrote:
>
> It sounds like everyone is in agreement that I should get rid of the
> single COW GUC tunable and provide two different tunables instead. I will
> update the patch to go back to the original name (wal_recycle) for the
> original WAL recycling behavior. The default value of that will be true to
> provide the existing behavior. This matches my original proposal from last
> year. I will add a new tunable (wal_init_zero) which will control the
> zero-fill behavior for the WAL file. Again, the default value will be true
> and provide the existing behavior. Both of these could (should) be set to
> false for a COW filesystem like ZFS.
>
> If anyone objects to this new approach, let me know, otherwise I'll start
> preparing an updated patch.
>
I have attached a new version of the patch that implements the changes
we've discussed over the past couple of days. Let me know if there are any
comments or suggestions.
Thanks,
Jerry
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-wal_recycle-and-wal_init_zero.patch | application/octet-stream | 9.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-03-07 21:26:29 | Re: PostgreSQL vs SQL/XML Standards |
| Previous Message | Laurenz Albe | 2019-03-07 20:00:24 | Small doc fix for pageinspect |