minor comments issue in ResultRelInfo src/include/nodes/execnodes.h

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: minor comments issue in ResultRelInfo src/include/nodes/execnodes.h
Date: 2024-08-12 10:03:22
Message-ID: CACJufxH8-NvFhLcSZZTTW+1M9AfS4+SOTKmyPG7ZhzNvN=+NkA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi.
{
/*
* For UPDATE/DELETE result relations, the attribute number of the row
* identity junk attribute in the source plan's output tuples
*/
AttrNumber ri_RowIdAttNo;

/* Projection to generate new tuple in an INSERT/UPDATE */
ProjectionInfo *ri_projectNew;

/* arrays of stored generated columns expr states, for INSERT and UPDATE */
ExprState **ri_GeneratedExprsI;
ExprState **ri_GeneratedExprsU;
}
for the struct ResultRelInfo, i've checked the above fields.

I think first ri_RowIdAttNo applies to MERGE also. so the comments may
not be correct?
Other files comments are fine.

see:
ExecInitModifyTable
/*
* For UPDATE/DELETE/MERGE, find the appropriate junk attr now, either
* a 'ctid' or 'wholerow' attribute depending on relkind. For foreign
* tables, the FDW might have created additional junk attr(s), but
* those are no concern of ours.
*/
if (operation == CMD_UPDATE || operation == CMD_DELETE ||
operation == CMD_MERGE)

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2024-08-12 10:06:52 Re: [bug fix] prepared transaction might be lost when max_prepared_transactions is zero on the subscriber
Previous Message Heikki Linnakangas 2024-08-12 09:55:00 Re: Refactoring postmaster's code to cleanup after child exit