| From: | jian he <jian(dot)universality(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: overflow bug for inhcounts |
| Date: | 2024-10-09 02:01:53 |
| Message-ID: | CACJufxGrBzKBrkPjQr1zSYbQ4Z-jJz-OUA36-_ZPTZhMKo+CFw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Oid
CreateConstraintEntry(const char *constraintName,
Oid constraintNamespace,
char constraintType,
....
int conInhCount,
bool conNoInherit,
bool conPeriod,
bool is_internal)
we can change
int conInhCount,
to
int16 conInhCount.
doing that, meaning we also need to refactor some of the caller functions.
we can also change
node Constraint field inhcount from int to int16.
the attached patch doing it.
while at it, minor changed CreateConstraintEntry caller's comments.
based on your patch.
| Attachment | Content-Type | Size |
|---|---|---|
| further_refactor_intcount.no-cfbot | application/octet-stream | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shinya Kato | 2024-10-09 02:10:37 | Set AUTOCOMMIT to on in script output by pg_dump |
| Previous Message | Tatsuo Ishii | 2024-10-09 01:53:50 | Re: pgbench: Improve result outputs related to failed transactinos |