Re: overflow bug for inhcounts

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: overflow bug for inhcounts
Date: 2024-10-10 16:38:36
Message-ID: 202410101638.qikdezkpvups@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024-Oct-09, jian he wrote:

> CreateConstraintEntry(const char *constraintName,

> we can change
> int conInhCount,
> to
> int16 conInhCount.
> doing that, meaning we also need to refactor some of the caller functions.

Good thought, thanks.

> we can also change
> node Constraint field inhcount from int to int16.

Nah, that field is unused, so I removed it. I gave another look at the
not-nulls branch, and we can do without it.

This is pushed, although there was a technical glitch (since fixed by
Magnus Hagander) and the pgsql-committers message was not sent. But you
can see it here:

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=fd64ed60b62697984bb69a09a3ae19fbe2905eb6

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-10-10 16:51:51 Re: allowing extensions to control planner behavior
Previous Message Alvaro Herrera 2024-10-10 16:13:18 Re: ECPG Refactor: move sqlca variable in ecpg_log()