Re: Remove dependence on integer wrapping

On Sat, Aug 10, 2024 at 11:41 PM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:
>
>
>
> On Thu, Aug 8, 2024 at 9:01 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> >
> > Should the error about integers be out of range?
> >
> > SELECT make_date(-2147483648, 1, 1);
> > "-2147483648" is not an allowed integer.
> >
> > \df make_date
> > List of functions
> > Schema | Name | Result data type | Argument data
> > types | Type
> > ------------+-----------+------------------+------------------------------------------+------
> > pg_catalog | make_date | date | year integer, month
> > integer, day integer | func
>
> Are you saying that with the patch applied you're seeing the above
> error? If so, I see a different error.
>
> test=# SELECT make_date(-2147483648, 1, 1);
> ERROR: date field value out of range
>
> Or are you saying that we should change the code in the patch so that
> it returns the above error? If so, I'm not sure I understand the
> reasoning. -2147483648 is an allowed integer, it's the minimum allowed
> value for integers.
>
> test=# SELECT (-2147483648)::integer;
> int4
> -------------
> -2147483648
> (1 row)
>

sorry, i mixed up
select (-2147483648)::int;
with
select -2147483648::int;

looks good to me.
maybe make it more explicit:
errmsg("date field (year) value out of range")));
i don't have a huge opinion though.