wrong comments in rewriteTargetListIU

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: wrong comments in rewriteTargetListIU
Date: 2025-04-10 08:57:20
Message-ID: CACJufxFMBe0nPXOQZMLTH4Ry5Gyj4m+2Z05mRi9KB4hk8rGt9w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi.

in function, rewriteTargetListIU
we have:

for (attrno = 1; attrno <= numattrs; attrno++)
{
/*
* Can only insert DEFAULT into generated columns, regardless of
* any OVERRIDING clauses.
*/
if (att_tup->attgenerated && !apply_default)
}

I think the above comments are wrong, since there are no
OVERRIDING clauses for the generated column.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-04-10 09:15:37 Re: sync_standbys_defined read/write race on startup
Previous Message jian he 2025-04-10 08:53:12 Re: bug in stored generated column over domain with constraints.