| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: wrong comments in rewriteTargetListIU |
| Date: | 2025-04-10 09:46:14 |
| Message-ID: | CA+HiwqGW_m1w6Np3SaGrWWAU4Ld0UAJCFSxdNOQYt94CB-WOXQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Apr 10, 2025 at 5:58 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> hi.
>
> in function, rewriteTargetListIU
> we have:
>
> for (attrno = 1; attrno <= numattrs; attrno++)
> {
> /*
> * Can only insert DEFAULT into generated columns, regardless of
> * any OVERRIDING clauses.
> */
> if (att_tup->attgenerated && !apply_default)
> }
>
> I think the above comments are wrong, since there are no
> OVERRIDING clauses for the generated column.
Hmm, I'm not sure that is quite right. See 17958972fe3b which added
the comment, especially the test cases that it adds.
--
Thanks, Amit Langote
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2025-04-10 09:52:14 | Correct documentation for protocol version |
| Previous Message | Amit Kapila | 2025-04-10 09:45:27 | Re: long-standing data loss bug in initial sync of logical replication |