Re: [Patch][pgAdmin4]: Fix pgagent issues

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Patch][pgAdmin4]: Fix pgagent issues
Date: 2020-04-21 11:10:18
Message-ID: CACCA4P3xSnkKi0F8-EgwM3QzkrYTLn_Mhdb_QiYdOuazCvapTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,

Please find the attached update patch with the fix.
Also fixed the Roles resql test cases as it was failing due to timezone
change.

Thanks,
Neel Patel

On Tue, Apr 21, 2020 at 12:32 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Neel
>
> RESQL test cases are failing on my machine due to different timezone
>
> - '2020-04-14 01:11:31-07'::timestamp with time zone, '2020-04-15
> 01:11:34-07'::timestamp with time zone,
> ? - ^ ^ ^ - ^
> ^ ^
> + '2020-04-14 13:41:31+05:30'::timestamp with time zone, '2020-04-15
> 13:41:34+05:30'::timestamp with time zone,
> ? + ^ ^ ^^^^
> + ^ ^ ^^^^
>
> Please fix the above issue and resend the patch.
>
> On Mon, Apr 20, 2020 at 3:07 PM Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
> wrote:
>
>> Hi,
>>
>> Please find the attached patch to stabilize the pgagent and fix below
>> issues.
>>
>> - Reverse engineering SQL and MSQL was incorrect when the user added
>> a job schedule with exception Fixes #5356
>> - Job schedule exception time was not showing correctly in SQL tab.
>> - Identify the job step and schedule if disabled from browser tree,
>> same as pgagent job - Fixes #4636
>> - Add RE-SQL/MSQL test cases for pgAgent Jobs - Fixes #4623
>>
>> Do review it and let me know for comments.
>>
>> Thanks,
>> Neel Patel
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

Attachment Content-Type Size
pgagent_V2.patch text/x-patch 98.5 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2020-04-21 11:20:04 Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default
Previous Message navnath gadakh 2020-04-21 11:04:57 Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default