Re: [pgAdmin4][patch]: Fix for RM 1320

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][patch]: Fix for RM 1320
Date: 2016-07-25 06:01:53
Message-ID: CACCA4P3dHgkPte+NYf3yMCXGm=zHo5aEaK5CaSe2n1Hmz2Zg2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Adding more details.

*Root cause:-*

When user change schema of already created fdw extension then while
creating the new fdw we should append the <schema_name>.<fdw_handler_name>.
Previously we added only <fdw_handler_name> so while executing the query it
will not be able to find fdw handler name without schema name.

e.g. If user changed the fdw handler 'postgres_fdw_handler' under schema
'test' then we should display the handler name under fdw as "test.
postgres_fdw_handler".

*Solution:-*

With this patch, we have added <schema_name>.<fdw_handler_name> so while
creating or updating the fdw, proper sql will be generated.

Thanks,
Neel Patel

On Mon, Jul 25, 2016 at 11:02 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> Hi,
>
> Please find attached patch file for the fix of RM- 1320.
>
> RM-1320 - Unable to create foreign data wrapper when user change the
> schema of extension 'postgres_fdw_handler'.
>
> Thanks,
> Neel Patel
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2016-07-25 06:13:40 Re: patch for RM1460 [pgAdmin4]
Previous Message Neel Patel 2016-07-25 05:32:02 [pgAdmin4][patch]: Fix for RM 1320