Re: [pgAdmin4][patch]: Fix for RM 1320

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][patch]: Fix for RM 1320
Date: 2016-07-25 11:48:24
Message-ID: CA+OCxowkVgcJ=GORAUR9UP2L9xtwq1Yib_kpeDU2ErwEU7ArtA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - applied.

On Mon, Jul 25, 2016 at 7:01 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> wrote:
> Adding more details.
>
> Root cause:-
>
> When user change schema of already created fdw extension then while creating
> the new fdw we should append the <schema_name>.<fdw_handler_name>.
> Previously we added only <fdw_handler_name> so while executing the query it
> will not be able to find fdw handler name without schema name.
>
> e.g. If user changed the fdw handler 'postgres_fdw_handler' under schema
> 'test' then we should display the handler name under fdw as "test.
> postgres_fdw_handler".
>
> Solution:-
>
> With this patch, we have added <schema_name>.<fdw_handler_name> so while
> creating or updating the fdw, proper sql will be generated.
>
> Thanks,
> Neel Patel
>
>
> On Mon, Jul 25, 2016 at 11:02 AM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
> wrote:
>>
>> Hi,
>>
>> Please find attached patch file for the fix of RM- 1320.
>>
>> RM-1320 - Unable to create foreign data wrapper when user change the
>> schema of extension 'postgres_fdw_handler'.
>>
>> Thanks,
>> Neel Patel
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-07-25 11:55:09 pgAdmin 4 commit: Make Save/Save As menu options work a little more san
Previous Message Dave Page 2016-07-25 11:48:15 pgAdmin 4 commit: Allow creation of FDWs if the extension is in a non-d