[pgAdmin4][runtime][patch]: Fix for RM#2679

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][runtime][patch]: Fix for RM#2679
Date: 2017-11-20 13:10:56
Message-ID: CACCA4P1oZWXwdwxooxDM7V+W8Y9fXdPMYoYVJubFxSoiLcO0Dg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find attached patch to fix RM#2679.

*Issue:-*
Getting started links does not open second time from "Dashboard" panel if
User close runtime tab and open any URL again.

*Analysis:-*
As in runtime Qt application, when user defined "target=_new" then
"createWindow" signal is called but when user close that new windows and
again click on link then "createWindow" signal is not getting called so
from user point view nothing will happen.

*Solution:-*
To make it work in both runtime and web application, changed "target"
attribute to "_blank" so that "createWindow" signal will be called every
time when user click on any link.

Do review it and let me know for comments.

Thanks,
Neel Patel

Attachment Content-Type Size
RM_2679.patch application/octet-stream 2.1 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-11-20 13:18:44 Re: [pgAdmin4][Patch]: Allow user to choose background colour for server
Previous Message Neel Patel 2017-11-20 07:06:38 Re: [pgAdmin4][patch][runtime]: RM#2829, RM#2491 - pgAdmin4 crashes while saving CSV data from Query tool