From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin4 PATCH: Domain Module |
Date: | 2016-01-20 07:20:44 |
Message-ID: | CACCA4P1caumXOrpEXrrETMuNGj3G3ctY-PN9=V6GUPF=dTBnWg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Khushboo,
While applying the patch file, we are getting below warnings.
#########################################
domains (1).patch:1340: trailing whitespace.
oid: undefined,
domains (1).patch:1483: trailing whitespace.
(nspname = 'pg_catalog' AND EXISTS
domains (1).patch:1487: trailing whitespace.
OR (nspname = 'information_schema' AND EXISTS
domains (1).patch:1489: trailing whitespace.
OR (nspname LIKE '_%' AND EXISTS
domains (1).patch:1642: trailing whitespace.
(select 1 from pg_class where relnamespace=typnamespace and relname =
typname and relkind != 'c') AND (typname not like '_%' OR NOT EXISTS
(select 1 from pg_class where relnamespace=typnamespace and relname =
substring(typname from 2)::name and relkind != 'c'))
warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.
#########################################
Can you please remove the whitespace and regenerate the patch ?
Thanks,
Neel Patel
On Wed, Jan 20, 2016 at 12:37 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Resending patch with binary option.
>
> On Wed, Jan 20, 2016 at 10:18 AM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find attached patch for the Domain Module.
>>
>> The patch will be modified after Types module implementation as we need
>> to populate Base Type and some Type related validations from the Types
>> module.
>>
>> Please review it and let me know the feedback.
>>
>> Thanks,
>> Khushboo
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2016-01-20 08:40:16 | Re: PATCH: Login/Group Role Node |
Previous Message | Khushboo Vashi | 2016-01-20 07:07:21 | Re: pgAdmin4 PATCH: Domain Module |