Re: Unable to update Domain properly

From: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Unable to update Domain properly
Date: 2016-01-13 17:27:15
Message-ID: CACCA4P095=s7tBwPTkgoHuhKndqMQxUfCX6bstiO01nym5JhPQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the attached patch file for fix of above issue.

*Issue:- *
Below generated SQL was wrong.

ALTER DOMAIN pem."TestDomain"
RENAME TO "TestDomain1";
ALTER DOMAIN pem."TestDomain"
DROP NOT NULL;

In second query, domain name is wrong as domain name was updated by the
first query.

*Resolution:-*

Now when any properties got changed along with domain name then correct SQL
will be generated.
Correct query should be as below.

ALTER DOMAIN pem."TestDomain"
RENAME TO "TestDomain1";
ALTER DOMAIN pem."TestDomain1"
DROP NOT NULL;

Please review it and do let us know for any comment.

Thanks,
Neel Patel

On Wed, Jan 13, 2016 at 6:43 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> While updating Domain from pgAdmin-III , I observed an error.
>
> When I update only Domain name it is working properly, but when I try to
> update multiple fields, I get an error.
>
> For example, if I try to rename Domain *TestDomain* to *TestDomain1* and
> also modifies one or more fields (except comment). I get below error.
>
>
> ERROR: type "pem.TestDomain" does not exist
>
> *Generated SQL:*
>
> ALTER DOMAIN pem."TestDomain"
> RENAME TO "TestDomain1";
> ALTER DOMAIN pem."TestDomain"
> DROP NOT NULL;
>
>
> Thanks,
> Khushboo
>

Attachment Content-Type Size
domain_fix.patch application/octet-stream 1.5 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Andreas 'ads' Scherbaum 2016-01-13 23:44:29 Re: Updated Greenplum documentation
Previous Message Khushboo Vashi 2016-01-13 13:13:13 Unable to update Domain properly