| From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Raise an exception under Python < 3.4 |
| Date: | 2020-04-29 09:13:02 |
| Message-ID: | CACCA4P08UBx6fRKNOcfSaXx8GXdneU2vZmAEbjBqY-ZMXO5=Lw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Dave,
Patch looks good to me except one condition as we do support from Python
3.4 onwards. I have modified that condition and attached the updated patch.
I have also removed the other references of Python2. Attached is the patch.
Do review it and let me know for comments.
Thanks,
Neel Patel
On Mon, Apr 27, 2020 at 9:27 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> The attached patch raises an exception if run under Python < 3.4. It also
> cleans up the README to remove references to Python 2 and removes Python
> 2-isms from the main config.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| Attachment | Content-Type | Size |
|---|---|---|
| Throw_an_exception_if_run_under_Python__=_3_3,_and_update_the_docs_and_main_config_for_Pyt_v2.patch | application/octet-stream | 5.3 KB |
| Remove_Python2_Reference_Core_files.patch | application/octet-stream | 19.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2020-04-29 09:21:57 | Re: Raise an exception under Python < 3.4 |
| Previous Message | navnath gadakh | 2020-04-29 09:08:57 | Re: [pgAdmin4] RESQL tests for Column & Type nodes |