| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, davinder singh <davindersingh2692(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG compilation error with Visual Studio 2015/2017/2019 |
| Date: | 2020-04-28 18:08:57 |
| Message-ID: | CAC+AXB3nHv2Xo6txjVW36Fz7-+8GT4N2SVTGTv_nfofksSBDYg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 27, 2020 at 1:20 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> I think we should backpatch this till 9.5 as I could see the changes
> made by commit 0fb54de9 to support MSVC2015 are present in that branch
> and the same is mentioned in the commit message. Would you like to
> prepare patches (and test those) for back-branches?
>
I do not have means to test these patches using Visual Studio previous to
2012, but please find attached patches for 9.5-9.6 and 10-11-12 as of
version 14. The extension is 'txt' not to break the cfbot.
> I have made few cosmetic changes in the attached patch which includes
> adding/editing a few comments, ran pgindent, etc. I have replaced the
> reference of "IETF-standardized" with "Unix-style" as we are already
> using it at other places in the comments as well.
LGTM.
Regards,
Juan José Santamaría Flecha
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-PG10-compilation-error-with-VS-2015-2017-2019_v14..txt | text/plain | 8.2 KB |
| 0001-PG9_5-compilation-error-with-VS-2015-2017-2019_v14.txt | text/plain | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Juan José Santamaría Flecha | 2020-04-28 18:14:55 | Re: PG compilation error with Visual Studio 2015/2017/2019 |
| Previous Message | Pavel Stehule | 2020-04-28 17:39:32 | Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays |