| From: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Vik Fearing <vik(at)postgresfriends(dot)org>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: MERGE ... RETURNING |
| Date: | 2023-07-11 20:58:20 |
| Message-ID: | CABwTF4XioqGAXf8DTDBqHj5Dv-oQoeS25gqnTo653c85xK-uSQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 11, 2023 at 1:43 PM Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
>
> In the above hunk, if there's an exception/ERROR, I believe we should
> PG_RE_THROW(). If there's a reason to continue, we should at least set
> rslot = NULL, otherwise we may be returning an uninitialized value to
> the caller.
Excuse the brain-fart on my part. There's not need to PG_RE_THROW(),
since there's no PG_CATCH(). Re-learning the code's infrastructure
slowly :-)
Best regards,
Gurjeet
http://Gurje.et
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-07-11 20:58:29 | Re: Cleaning up threading code |
| Previous Message | Tristan Partin | 2023-07-11 20:57:34 | Re: Extensible storage manager API - SMGR hook Redux |