| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleaning up threading code |
| Date: | 2023-07-11 20:58:29 |
| Message-ID: | CA+hUKGJggGdDOdkoJXmrQwHFgY5zYenNod3SKNjGzsiz6+vUdA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 10, 2023 at 10:45 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> * defined ENABLE_THREAD_SAFETY 1 in c.h, for the benefit of extensions
I may lack imagination but I couldn't think of any use for that
vestigial macro in backend/extension code, and client code doesn't see
c.h and might not get the right answer anyway if it's dynamically
linked which is the usual case. I took it out for now. Open to
discussing further if someone can show what kinds of realistic
external code would be affected.
> * defined ENABLE_THREAD_SAFETY 1 ecpg_config.h, for the benefit of ECPG clients
I left this one in. I'm not sure if it could really be needed.
Perhaps at a stretch, perhaps ECPG code that is statically linked
might test that instead of calling PQisthreadsafe().
Pushed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2023-07-11 21:11:02 | Re: Parallel CREATE INDEX for BRIN indexes |
| Previous Message | Gurjeet Singh | 2023-07-11 20:58:20 | Re: MERGE ... RETURNING |