Re: Document that server will start even if it's unable to open some TCP/IP ports

From: Gurjeet Singh <gurjeet(at)singh(dot)im>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Postgres Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Document that server will start even if it's unable to open some TCP/IP ports
Date: 2023-06-13 06:57:45
Message-ID: CABwTF4XJsbyJGX8HE2qdhL8CAffsx-EZHghaNnVF539Cbwehtg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 12, 2023 at 10:59 PM Nathan Bossart
<nathandbossart(at)gmail(dot)com> wrote:
> On Sat, May 27, 2023 at 03:17:21PM -0700, Gurjeet Singh wrote:
> > If listen_addresses is empty, then server won't try to open any TCP/IP
> > ports. The patch does not change any language related to that.
>
> Your proposed change notes that the server only starts if it can listen on
> at least one TCP/IP address, which I worry might lead folks to think that
> the server won't start if listen_addresses is empty.

Perhaps we can prefix that statement with "If listen_addresses is not
empty", like so:

--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -661,3 +661,9 @@ include_dir 'conf.d'
which allows only local TCP/IP <quote>loopback</quote>
connections to be
- made. While client authentication (<xref
+ made. If <varname>listen_addresses</varname> is not empty, the server
+ will start only if it can open the <varname>port</varname>
+ on at least one TCP/IP address. If server is unable to open
+ <varname>port</varname> on a TCP/IP address, it emits a warning.
+ <para>
+ </para>
+ While client authentication (<xref
linkend="client-authentication"/>) allows fine-grained control

Best regards,
Gurjeet
http://Gurje.et

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2023-06-13 07:02:01 Re: add non-option reordering to in-tree getopt_long
Previous Message Konstantin Knizhnik 2023-06-13 06:55:36 Re: Let's make PostgreSQL multi-threaded