| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
| Cc: | Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Document that server will start even if it's unable to open some TCP/IP ports |
| Date: | 2023-06-13 05:59:27 |
| Message-ID: | 20230613055927.GB211254@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 27, 2023 at 03:17:21PM -0700, Gurjeet Singh wrote:
> Upon further testing, I saw that server will not start only if it is
> unable to open the port on _all_ the interfaces/addresses. It it's
> able to open the port on at least one, the server will start.
This surprised me. I would've expected the server to fail to start if it
failed for anything in listen_addresses. After some digging, I found what
I believe is the original justification [0] as well as a follow-up thread
[1] that seems to call out kernel support for IPv6 as the main objection.
Perhaps it is time to reevaluate this decision.
> If listen_addresses is empty, then server won't try to open any TCP/IP
> ports. The patch does not change any language related to that.
Your proposed change notes that the server only starts if it can listen on
at least one TCP/IP address, which I worry might lead folks to think that
the server won't start if listen_addresses is empty.
[0] https://postgr.es/m/6739.1079384078%40sss.pgh.pa.us
[1] https://postgr.es/m/200506281149.51696.peter_e%40gmx.net
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-06-13 06:11:14 | Re: Improve logging when using Huge Pages |
| Previous Message | Gurjeet Singh | 2023-06-13 05:58:54 | Re: RFC: Adding \history [options] [filename] to psql (Snippets and Shared Queries) |