| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Date: | 2025-01-20 08:03:54 |
| Message-ID: | CABdArM7Qk9mdy+4ZDVyBWwo+hwNBqCXM=CpHRpe1f8WxEJUgjA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 17, 2025 at 6:50 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> Hi Nisha,
>
> Thanks for providing an updated patch. I have tested the patch and ran
> some tests. The patch works fine. I have few comments:
>
Thanks for your review. Attached are the v61 patches.
I've addressed the comments and rebased patches as needed due to the
latest changes on pgHead. The patch-0002 test file name has been
updated from "043_invalidate_inactive_slots.pl" to
"044_invalidate_inactive_slots.pl".
--
Thanks,
Nisha
| Attachment | Content-Type | Size |
|---|---|---|
| v61-0001-Enhance-replication-slot-error-handling-slot-inv.patch | application/octet-stream | 15.7 KB |
| v61-0002-Introduce-inactive_timeout-based-replication-slo.patch | application/octet-stream | 31.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-01-20 08:21:35 | Re: Statistics Import and Export |
| Previous Message | Daniel Gustafsson | 2025-01-20 07:54:04 | Re: Replace current implementations in crypt() and gen_salt() to OpenSSL |