| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve the connection failure error messages |
| Date: | 2024-03-22 10:42:39 |
| Message-ID: | CABdArM5mu1A8zyqsEhckaser-1d2AXgkVrEqqJNJKV5=0N9shg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 13, 2024 at 11:16 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> FYI -- some more code has been pushed since this patch was last
> updated. AFAICT perhaps you'll want to update this patch again for the
> following new connection messages on HEAD:
>
> - slotfuncs.c [1]
> - slotsync.c [2]
>
> ----------
> [1] https://github.com/postgres/postgres/blob/0b84f5c419a300dc1b1a70cf63b9907208e52643/src/backend/replication/slotfuncs.c#L989
> [2] https://github.com/postgres/postgres/blob/0b84f5c419a300dc1b1a70cf63b9907208e52643/src/backend/replication/logical/slotsync.c#L1258
>
Thanks for the update.
Here is the v4 patch with changes required in slotfuncs.c and slotsync.c files.
--
Thanks,
Nisha
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Improve-the-connection-failure-error-messages.patch | application/octet-stream | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-03-22 10:46:19 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Maxim Orlov | 2024-03-22 10:27:23 | Re: Refactoring of pg_resetwal/t/001_basic.pl |